Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the way of generating XDR classes. #506

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Optimize the way of generating XDR classes. #506

merged 3 commits into from
Aug 11, 2023

Conversation

overcat
Copy link
Member

@overcat overcat commented Aug 10, 2023

Closes #502

sreuland
sreuland reviewed Aug 10, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
sreuland
sreuland reviewed Aug 10, 2023
View reviewed changes
readme.md Show resolved Hide resolved
sreuland
sreuland approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@sreuland sreuland left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for adding this tool/feature!

@overcat overcat changed the title [WIP] Optimize the way of generating XDR classes. Optimize the way of generating XDR classes. Aug 10, 2023
@overcat overcat marked this pull request as ready for review August 10, 2023 23:36
@overcat
Copy link
Member Author

overcat commented Aug 10, 2023

Ready for merge!

@sreuland sreuland merged commit 9c78566 into lightsail-network:soroban Aug 11, 2023
@overcat overcat deleted the generate-xdr branch August 11, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreuland sreuland sreuland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@overcat @sreuland